-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WooPay opt-in blocks field #9131
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +1.1 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also check please autofill of the phone number? Manual entry works as expected but autofill looks incorrect. |
@leonardola fixed on 3480ce0 |
@pierorocca this PR addresses that too. |
I thought so Alefe based on the field color. Thanks for confirming. |
1 similar comment
I thought so Alefe based on the field color. Thanks for confirming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leonardola I think this is expected, one |
@nikkivias could you confirm? |
While we're waiting for design input, looking at the original Figma designs from the Blocks refresh work, "Save my info" looks clearly associated with the Payment Options section. When there's a section below, the hr is introduced. When there isn't an additional section, it doesn't look like an hr is added. |
@pierorocca at least on WooCommerce 9.1, on mobile the hr is added on every section. |
Gotch @alefesouza. Yeah definitely need design validation. |
Hi team, confirming that the line separator shows up per section on mobile. You will notice the same if your scroll higher and inspect other sections. Although I thought |
@nikkivias got it, looking Leonardo's screenshots here, do you think any change is needed? |
Hi @pierorocca @alefesouza @leonardola and team Coming in here with screenshots I would say that DesktopAdd separator line above MobileKeep as is. |
I think the ideal state is possible @alefesouza since that's our WooPayments component correct? |
@pierorocca yes, I've implemented it on the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes #9102
Changes proposed in this Pull Request
Fix the WooPay opt-in blocks fields spacing issue when running on WooCommerce 9.1+.
Probably related to woocommerce/woocommerce#47565.
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge